Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme clean up #2942

Merged
merged 10 commits into from Mar 21, 2020
Merged

Dark theme clean up #2942

merged 10 commits into from Mar 21, 2020

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 20, 2020 •
edited

Done

Fixes #2894

Update theme implementation in patterns to use mixins.

QA

@webteam-app
Copy link

Starting demo at: https://vanilla-framework-canonical-web-and-design-pr-2942.run.demo.haus/

@bartaz bartaz changed the title WIP: Dark theme clean up Dark theme clean up Mar 20, 2020
lyubomir-popov
lyubomir-popov approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @bartaz

@bartaz bartaz merged commit c63f3ef into canonical:master Mar 21, 2020
@bartaz bartaz deleted the dark-theme branch March 21, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyubomir-popov lyubomir-popov lyubomir-popov approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 Review: Code +1 Review: Design +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore implementation improvements for themes
3 participants
@bartaz @webteam-app @lyubomir-popov