New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark theme to the buttons #3807
Conversation
Demo starting at https://vanilla-framework-3807.demos.haus |
1c0522e
to
764cc41
Compare
@lyubomir-popov Can you review and update colors where needed? |
@spencerbygraves @bartaz what do you think of these? The darker ones are more traditional, similar to what github and apple do. The lighter ones stick out more, and borrow from the material design theory that colors on dark should be desaturated and lightend to become more readable. Full benchmaring doc here |
@lyubomir-popov Personally for me the top (option A) feels more like a dark variant of our buttons. With desaturated bottom ones I wasn't sure if they are disabled. |
@lyubomir-popov I also prefer the top ones but I think they could be lighter. |
@bartaz just spoke to @spencerbygraves, can we use |
f7636b8
to
44c2a1c
Compare
44c2a1c
to
b3bea25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Design +1 and percy approved @bartaz |
Done
WIP
Demo: https://vanilla-framework-3807.demos.haus/docs/examples/patterns/buttons/dark
Fixes #3779
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots