Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme to the buttons #3807

Merged
merged 9 commits into from Jul 1, 2021
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jun 24, 2021

Done

WIP

Demo: https://vanilla-framework-3807.demos.haus/docs/examples/patterns/buttons/dark

Fixes #3779

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the component status page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

Screenshot 2021-06-30 at 17 16 12

@webteam-app
Copy link

Demo starting at https://vanilla-framework-3807.demos.haus

scss/_patterns_buttons.scss Outdated Show resolved Hide resolved
scss/_patterns_buttons.scss Outdated Show resolved Hide resolved
@bartaz
Copy link
Contributor Author

bartaz commented Jun 25, 2021

@lyubomir-popov Can you review and update colors where needed?

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jun 29, 2021

@spencerbygraves @bartaz what do you think of these?

image

The darker ones are more traditional, similar to what github and apple do. The lighter ones stick out more, and borrow from the material design theory that colors on dark should be desaturated and lightend to become more readable.

Full benchmaring doc here

@bartaz
Copy link
Contributor Author

bartaz commented Jun 30, 2021

@lyubomir-popov Personally for me the top (option A) feels more like a dark variant of our buttons. With desaturated bottom ones I wasn't sure if they are disabled.

@spencerbygraves
Copy link

@lyubomir-popov I also prefer the top ones but I think they could be lighter.

@bartaz bartaz added the Feature 馃巵 New feature or request label Jun 30, 2021
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jun 30, 2021

@bartaz just spoke to @spencerbygraves, can we use #008013 and #A11223 for positive/negative colours in the default state? Then apply the hover/active state percentages to those.

image

@bartaz bartaz changed the title WIP: Button dark theme Add dark theme to the buttons Jun 30, 2021
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lyubomir-popov
Copy link
Contributor

Design +1 and percy approved @bartaz

@bartaz bartaz merged commit 47d6001 into canonical:master Jul 1, 2021
@bartaz bartaz deleted the button-dark-theme branch July 1, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base button is white on grey background
5 participants