Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rockcraft projects for pytorch full CPU image #47

Open
DnPlas opened this issue Mar 15, 2024 · 5 comments
Open

Create rockcraft projects for pytorch full CPU image #47

DnPlas opened this issue Mar 15, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Mar 15, 2024

Why it needs to get done

The DSS project allows users to select the image of the Notebook server to be used, some of which are built and distributed by this team.

What needs to get done

  1. Create a rockcraft project for the pytorch full Notebook Server image. Use this Dockerfile for reference.
  2. Add sanity tests to the rock.

When is the task considered done

When the pytroch full CPU image is published in the CKF team Dockerhub repository.

@DnPlas DnPlas added the enhancement New feature or request label Mar 15, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5462.

This message was autogenerated

@misohu
Copy link
Member

misohu commented Mar 18, 2024

Today I was working on this looks like we already have this rock created for kubeflow here. After discussion on daily we decided to use those rocks form kubeflow-rocks repo. On top of these we will install mlflow library. At the time of planning we forgot about those rocks.

@misohu
Copy link
Member

misohu commented Mar 19, 2024

Checking the code in here today. I found out that the upstream branch 1.8-branch has changed completely so we can no longer build the rocks the same way as we did originally. Key differences:

  • each sub base image (jupyter, jupyter-pytorch) is not installing key requirements from requirements.txts but rather inside the docker file example
  • names of the files has changed e.g. ther is no longer cpu-requirements.txt in jupyter-pytorch folder.
  • upstream uses mamba to install dependancies to support arm64

because of this we need to rewrite each rockcraft yaml.

@misohu
Copy link
Member

misohu commented Mar 19, 2024

After talking with @DnPlas we agreed on following:

  • I will rewrite the pytorch cpu jupyter ROCK to match the upstream Dockerfile except the s6 updates which are not needed for this task. PR is here.
  • I will open this issue.

@misohu
Copy link
Member

misohu commented Mar 20, 2024

During the testing of the new ROCK I was facing problems with trivy timing out. I openned this PR to increase the default timeout canonical/charmed-kubeflow-workflows#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants