Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipass does not recognize Hyper-V instances as bridged #3489

Open
ricab opened this issue Apr 16, 2024 · 1 comment · May be fixed by #3513
Open

Multipass does not recognize Hyper-V instances as bridged #3489

ricab opened this issue Apr 16, 2024 · 1 comment · May be fixed by #3513
Assignees
Labels
bug medium medium importance
Milestone

Comments

@ricab
Copy link
Collaborator

ricab commented Apr 16, 2024

Describe the bug
The Multipass daemon keeps thinking that bridged instances aren't bridged, when the bridged-network is set to an non-bridge interface, in Hyper-V. If asked to set bridge=true again, it will then duplicate the bridged interface.

The problem is that the bridge is not associated with the interface here. This appears to be a forgotten placeholder and shouldn't be hard to fix.

VirtualBox doesn't have a dedicated implementation, but I think we don't need bridges there and just pass the end interface, so this shouldn't apply there.

To Reproduce

C:\> multipass get local.bridged-network
Ethernet Instance 0
C:\> multipass get local.glad-menhaden.bridged
false
C:\> multipass set local.glad-menhaden.bridged=true
C:\> multipass get local.glad-menhaden.bridged
false
C:\> multipass set -vvvv local.glad-menhaden.bridged=true
C:\> multipass set -vvvv local.glad-menhaden.bridged=true

The instance now has 3 new bridged networks.

Expected behavior
The bridge would be recognized and a second attempt to make the setting true would be a no op.

Additional info

  • OS: Windows
  • multipass version
  • multipass get local.driver=hyper-v
@ricab ricab added bug needs triage Issue needs to be triaged labels Apr 16, 2024
@ricab
Copy link
Collaborator Author

ricab commented Apr 16, 2024

This will be an issue for QEMU too once networking is implemented on Linux. On macOS we don't need bridges, so we don't see it there today.

I believe the generic fix would be to call find_bridge_with which implements exactly this.

@ricab ricab changed the title Multipass does not Hyper-V instances as bridged Multipass does not recognize Hyper-V instances as bridged Apr 16, 2024
@townsend2010 townsend2010 removed the needs triage Issue needs to be triaged label Apr 16, 2024
@townsend2010 townsend2010 added this to the 1.14.0 milestone Apr 16, 2024
@ricab ricab added the medium medium importance label Apr 17, 2024
@luis4a0 luis4a0 linked a pull request Apr 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug medium medium importance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants