Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should fail if a tox env doesn't exist #64

Closed
sed-i opened this issue Apr 13, 2023 · 1 comment
Closed

CI should fail if a tox env doesn't exist #64

sed-i opened this issue Apr 13, 2023 · 1 comment

Comments

@sed-i
Copy link
Contributor

sed-i commented Apr 13, 2023

tox will happily pass for non-existing testenvs:

$ tox -e volkswagen
  volkswagen: OK (0.84 seconds)
  congratulations :) (0.87 seconds)

This is especially misleading when instead of unit we have unit-k8s and unit-machine.

We should probably change the CI command to run tox to:

if tox -l | grep -q '^unit$'; then tox -e unit; else echo "Error: 'unit' testenv does not exist"; fi
@lucabello
Copy link
Contributor

Funnily enough, it seems like this was solved upstream: tox-dev/tox#3089

The tox 4.9.0 release https://github.com/tox-dev/tox/releases/tag/4.9.0 includes that change. Our CI is using the latest tox version, so nothing to do here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants