Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes don't mention all released PRs #1055

Open
bartaz opened this issue Mar 19, 2024 · 4 comments
Open

Release notes don't mention all released PRs #1055

bartaz opened this issue Mar 19, 2024 · 4 comments

Comments

@bartaz
Copy link
Contributor

bartaz commented Mar 19, 2024

It seems that release notes on GH only list a single merged PR, not everything that is part of the release.

For example release 0.50.6: https://github.com/canonical/react-components/releases/tag/v0.50.6

It included at least:

Not sure how the current automatic releases with semantic-release work?

@bartaz
Copy link
Contributor Author

bartaz commented Mar 19, 2024

There is some "release notes generator" step, maybe that's where the issue is?

[9:51:30 AM] [semantic-release] › ℹ  The next release version is 0.50.6
[9:51:30 AM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[9:51:30 AM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[9:51:30 AM] [semantic-release] › ℹ  Start step "prepare" of plugin "@semantic-release/changelog"
[9:51:30 AM] [semantic-release] [@semantic-release/changelog] › ℹ  Create /home/runner/work/react-components/react-components/CHANGELOG.md

@jmuzina
Copy link
Member

jmuzina commented May 17, 2024

The last release that had multiple PRs was 0.47.3.

The release notes generator was updated in #1030 . This PR bumped the release labeller from v4 to v5, perhaps this caused our issue?

@mas-who do you know anything more about this?

@mas-who
Copy link
Contributor

mas-who commented May 20, 2024

The last release that had multiple PRs was 0.47.3.

The release notes generator was updated in #1030 . This PR bumped the release labeller from v4 to v5, perhaps this caused our issue?

@mas-who do you know anything more about this?

@jmuzina yes the 0.47.3 release was the last release prior to semantic-release was enabled in #1024. Since semantic-release triggers a release workflow on push to main, it is expected that every merged PR would be a separate release. PR #1030 fixed the issue of pull-request-labeler github action breaking CI and is not related to semantic-release.

There is a guide on how PR titles should be formulated for semantic-release to trigger a release, I think perhaps that is related to the issue @bartaz raised?

@petermakowski any thoughts on this?

@petermakowski
Copy link
Contributor

Not sure how the current automatic releases with semantic-release work?

semantic-release works as expected (but can be changed in the configuration if we choose to do so).

We're using defaults for release notes generator and can be customised as explained here: https://github.com/conventional-changelog/conventional-changelog-config-spec/blob/master/versions/2.0.0/README.md

As we're currently creating a release on every push to main, release notes will always have a single item.
Release notes don't mention commits that are not relevant for the consumer of the component library (such as test, refector etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants