New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop click event propagation in Modal #1058
fix: stop click event propagation in Modal #1058
Conversation
Demo starting at https://react-components-1058.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've QAed this with Juju Dashboard and it works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This PR is included in version 0.51.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
Modal
and when closing or confirmingConfirmationModal
.QA
Modal
andConfirmationModal
renders as expected in storybook.ConfirmationModal
will be rendered in aPortal
. Clicking the close button used to close the panel, but, using the changes in this PR, it doesn't.Fixes