New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design guidelines from discourse to Vanilla docs markdown #4927
Conversation
Demo starting at https://vanilla-framework-4927.demos.haus |
430f8c5
to
8d0bb43
Compare
As discussed on Design System Working Group meeting today, the status of design documentation is currently being discussed and the final shape of it is yet to be defined. Therefore we don't want to publish these docs at this time, as they don't reflect what the spec should look like. I don't want to be throwing away this piece of work as a whole, because while content may not be final, the code changes to make design guidelines show as a new tab are valid and needed. So I think we can drop the markdown content (and the relevant design guidelines config from the yaml file), but keep any other changes. So the new pages can be easily added once needed. |
74ea397
to
252611a
Compare
As per discussion in roadmap review meeting, we want to include the existing documentation as is and improve on top of that if needed later. I'm cleaning up this PR and preparing it for review. |
We need to figure out how to make images better and consistent in terms of size, but for now this is good enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @aaryanporwal for the initial work on this, it's good to see it go through finally.
Thanks for taking it forward @bartaz. |
Done
Migrated corresponding design guidelines into a new tab besides implementation and accessibility tab.
Source of the docs: https://discourse.ubuntu.com/c/design-system/98
QA