Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design guidelines from discourse to Vanilla docs markdown #4927

Merged
merged 5 commits into from Apr 5, 2024

Conversation

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4927.demos.haus

@aaryanporwal aaryanporwal added Feature 🎁 New feature or request Documentation 📝 Documentation changes or updates labels Nov 30, 2023
bartaz
bartaz previously requested changes Nov 30, 2023
templates/_layouts/_component_tabs.html Outdated Show resolved Hide resolved
@aaryanporwal aaryanporwal changed the title Add design guidelines for switch, slider and matrix [WD-7629, WD-7630, WD-7631] Add design guidelines from discourse to Vanilla docs markdown [WD-7623] Dec 11, 2023
@bartaz
Copy link
Contributor

bartaz commented Dec 11, 2023

As discussed on Design System Working Group meeting today, the status of design documentation is currently being discussed and the final shape of it is yet to be defined. Therefore we don't want to publish these docs at this time, as they don't reflect what the spec should look like.

I don't want to be throwing away this piece of work as a whole, because while content may not be final, the code changes to make design guidelines show as a new tab are valid and needed. So I think we can drop the markdown content (and the relevant design guidelines config from the yaml file), but keep any other changes. So the new pages can be easily added once needed.

@bartaz bartaz dismissed their stale review April 3, 2024 12:22

Updated

@bartaz
Copy link
Contributor

bartaz commented Apr 3, 2024

As per discussion in roadmap review meeting, we want to include the existing documentation as is and improve on top of that if needed later.

I'm cleaning up this PR and preparing it for review.

@danielmutis
Copy link

We need to figure out how to make images better and consistent in terms of size, but for now this is good enough.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @aaryanporwal for the initial work on this, it's good to see it go through finally.

@bartaz bartaz merged commit 9495070 into canonical:main Apr 5, 2024
5 checks passed
@bartaz bartaz changed the title Add design guidelines from discourse to Vanilla docs markdown [WD-7623] Add design guidelines from discourse to Vanilla docs markdown Apr 5, 2024
@aaryanporwal
Copy link
Member Author

Thanks for taking it forward @bartaz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants