Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height mismatch between search box and search and filter #4984

Open
lorumic opened this issue Feb 8, 2024 · 3 comments
Open

Height mismatch between search box and search and filter #4984

lorumic opened this issue Feb 8, 2024 · 3 comments
Assignees
Labels

Comments

@lorumic
Copy link
Contributor

lorumic commented Feb 8, 2024

Describe the bug

In the current implementation, due to the spacing around the search icon (which is present only in the search box), the search box has bigger height than the search and filter (1px difference). See screenshots below.

To Reproduce

Steps to reproduce the behavior:

This can be easily checked by inspecting the examples on the VF website docs (as shown in the screenshots below).

Expected behavior

Ideally, both components should have the exact same height. So that when we have a mix of them in different pages of our app, and they're always in the same position of the page, we don't see a 1px "jump" when switching pages.

Screenshots

  • Search box:

image

  • Search and filter:

image

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Google Chrome
  • Version: 121.0.6167.160
@lorumic lorumic changed the title Fix height mismatch between search box and search and filter Height mismatch between search box and search and filter Feb 8, 2024
@codeEmpress1 codeEmpress1 self-assigned this Feb 29, 2024
@bartaz

This comment was marked as duplicate.

@lorumic
Copy link
Contributor Author

lorumic commented Mar 5, 2024

The issue seems to still be there. If you put search box component side by side the search and filter there is a 1px difference.

Hey @bartaz - I think you wanted to post this comment in the PR. This is the issue :)

@bartaz
Copy link
Contributor

bartaz commented Mar 5, 2024

The issue seems to still be there. If you put search box component side by side the search and filter there is a 1px difference.

Hey @bartaz - I think you wanted to post this comment in the PR. This is the issue :)

Ah, yes, I don't know how this happened. I must have clicked a wrong link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants