Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application layout doesn't accommodate tag logos #5014

Open
steverydz opened this issue Feb 29, 2024 · 2 comments
Open

Application layout doesn't accommodate tag logos #5014

steverydz opened this issue Feb 29, 2024 · 2 comments
Labels
WG: Validated Validate working group proposals

Comments

@steverydz
Copy link
Contributor

Component/pattern to amend

The application layout

Visual

Screenshot 2024-02-29 at 15 45 55 Screenshot 2024-02-29 at 15 47 53

Context

The application layout doesn't allow for latest logos which include a tag and are intended to have no space between them and the top of the screen.

There is also a related issue where in the examples the circle/icon is separate from the word mark which is for the unpinned navigation on narrow viewports. This doesn't work with this type of logo as the text isn't the same height of the logo tag/icon.

@steverydz steverydz added WG: Proposal Working group proposals and removed WG: Proposal Working group proposals labels Feb 29, 2024
@bartaz
Copy link
Contributor

bartaz commented Feb 29, 2024

Yes, that's long overdue. We had an attempt on addressing this (#4691), but it got blocked on an ongoing redesign/spec of the whole side navigation.

But I guess it's good to bring this back to attention and decide on WG how to proceed with this.

So far I think some apps (Anbox, LXD, etc) have some local solutions around this problem, so maybe this can be shared somehow.

@bartaz bartaz added the WG: Proposal Working group proposals label Mar 13, 2024
@danielmutis
Copy link

WG: This issue is validated. We have some solutions in the new side nav spec, which hasn't been fully approved yet. This includes more changes than just the logo. For now, there will be some short-term solutions to this problem until we get a finalised side nav.

@danielmutis danielmutis added WG: Validated Validate working group proposals and removed WG: Proposal Working group proposals labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG: Validated Validate working group proposals
Projects
None yet
Development

No branches or pull requests

3 participants