Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default info icon to standard colour #5027

Merged
merged 1 commit into from Mar 18, 2024

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 13, 2024

Done

Reverts the default info icon to standard icon colour while keeping the icon in notification coloured blue.

QA

Screenshots

image image

but keep notification icon coloured
@webteam-app
Copy link

Demo starting at https://vanilla-framework-5027.demos.haus

@bartaz bartaz marked this pull request as ready for review March 13, 2024 15:28
@bartaz bartaz added Review: QA needed Review: Code needed Bug 🐛 Review: Percy needed This PR needs a review of Percy for visual regressions labels Mar 13, 2024
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - I was in a rabbit hole yesterday. LGTM! 👍

@bartaz bartaz merged commit 37cb2a5 into canonical:main Mar 18, 2024
5 checks passed
@bartaz
Copy link
Contributor Author

bartaz commented Mar 18, 2024

Oh, I missed that. It was supposed to be part of Vanilla 4.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants