Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move active/hover button opacity variables to settings #5029

Merged
merged 1 commit into from Mar 18, 2024

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 18, 2024

Done

Moved active and hover button background variables to colour settings (where they are needed), so that button pattern file does not need to be imported for settings to work.

QA

  • Just make sure CI is good (all builds and tests pass)

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details

@webteam-app
Copy link

Demo starting at https://vanilla-framework-5029.demos.haus

@bartaz bartaz marked this pull request as ready for review March 18, 2024 09:40
Copy link
Contributor

@minkyngkm minkyngkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit ea1849c into canonical:main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants