Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Firefox) Holding shift while clicking a checkbox causes the click to not be registered #5044

Open
ndv99 opened this issue Apr 3, 2024 · 4 comments
Labels

Comments

@ndv99
Copy link

ndv99 commented Apr 3, 2024

Describe the bug

In Firefox, if you hold down your shift key on a keyboard and click a checkbox, the click is not registered.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://vanillaframework.io/docs/base/forms#checkbox
  2. Shift + click on a checkbox
  3. See checkbox not being checked

Expected behavior

  1. Go to https://vanillaframework.io/docs/base/forms#checkbox
  2. Shift + click on a checkbox
  3. See checkbox being checked

Desktop (please complete the following information):

  • OS: Kubuntu 23.10
  • Browser: Firefox (snap)
  • Version 124.0

Additional context

This appears to be related to a "bug" in Firefox where shift+clicking checkbox labels doesn't check the checkbox. Vanilla checkboxes are also always wrapped in a label, hence the behaviour we see.

@ndv99 ndv99 added the Bug 🐛 label Apr 3, 2024
@bartaz
Copy link
Contributor

bartaz commented Apr 3, 2024

Well, that doesn't look promising:

image

@ndv99
Copy link
Author

ndv99 commented Apr 3, 2024

Well, that doesn't look promising:

My thoughts exactly 😂

@bartaz
Copy link
Contributor

bartaz commented Apr 3, 2024

Thanks for context @ndv99, I'm not sure if there is much we can do to remedy that.

BTW, what's the context of shift+click being used? You wanted to implement some kind of batch selection?

@ndv99
Copy link
Author

ndv99 commented Apr 3, 2024

Thanks for context @ndv99, I'm not sure if there is much we can do to remedy that.

BTW, what's the context of shift+click being used? You wanted to implement some kind of batch selection?

You're absolutely right. We've implemented batch selection of machines in MAAS UI with shift+click. Works on Chrome, just not on FF :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants