Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-equal-height-row: remove padding-bottom, make separators muted #5065

Closed
lyubomir-popov opened this issue Apr 24, 2024 · 3 comments
Closed
Assignees

Comments

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Apr 24, 2024

Can we please:

  1. remove the padding-bottom. Sometimes a section contains other ocntent underneath, so the end of section regular ssection spacing doesn't work here. best to let people wrap it in p-section or p-section--shallow as needed

  2. Can we please make the separators muted. I'm introducing a new convention of making section level hrs default colour, and any secondary hrs inside a given section - muted colour. This makes it easier to see which section things are part of.

For example, in the below screenshot, the divider inside the equal height row should be muted, not default colour as it is here. Also notice the duplicated spacing at the bottom due to [1] ^
image

  1. have a 1 char difference between 1st, 2nd, 3rd separator - 3chars slows you down
@lyubomir-popov lyubomir-popov added the WG: Proposal Working group proposals label Apr 24, 2024
@lyubomir-popov
Copy link
Contributor Author

also, a bug: we need the third separator hidden on medium:
image

@bartaz
Copy link
Contributor

bartaz commented Apr 29, 2024

also, a bug: we need the third separator hidden on medium

@lyubomir-popov we have a bug open for the separators: #5062

@bartaz bartaz added Maintenance 🔨 and removed WG: Proposal Working group proposals labels Apr 29, 2024
@bartaz bartaz self-assigned this Apr 30, 2024
@bartaz
Copy link
Contributor

bartaz commented Apr 30, 2024

@bartaz bartaz closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants