Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcfly stopped working (kernel issue) #371

Closed
hferreiro opened this issue Jul 4, 2023 · 17 comments
Closed

mcfly stopped working (kernel issue) #371

hferreiro opened this issue Jul 4, 2023 · 17 comments

Comments

@hferreiro
Copy link

hferreiro commented Jul 4, 2023

Since some time ago, I cannot get mcfly to work. After running its UI with ctrl-r, pressing enter or tab on any row just goes back to bash with an empty prompt.

I tried emptying my .bashrc or running mcfly -d search directly without success. Is there any way to debug this issue?

@cantino
Copy link
Owner

cantino commented Jul 7, 2023

Does mcfly --version give output? And I assume you have eval "$(mcfly init bash)" in your bashrc?

@yingmanwumen
Copy link

I got the same mistake, and this is my bash and mcfly versions:
bash: 5.2.15
mcfly: 0.8.1

@yingmanwumen
Copy link

this issue would help:
dvorka/hstr#478

@hferreiro
Copy link
Author

Does mcfly --version give output? And I assume you have eval "$(mcfly init bash)" in your bashrc?

Yes, it's initialized as that. Running mcfly works, what's not working is selecting something in its UI.

@hferreiro
Copy link
Author

this issue would help: dvorka/hstr#478

I can confirm this is the issue. The workaround at dvorka/hstr#478 (comment) is working for me:

$ sysctl -w dev.tty.legacy_tiocsti=1

@yingmanwumen
Copy link

@cantino hstr is going to fix the same issue in the next release: dvorka/hstr#486. Would mcfly fix this?

@cantino
Copy link
Owner

cantino commented Aug 17, 2023

If someone wants to work on this, I'd be happy to accept a fix. Does setting READLINE_LINE have the same effect as using tiocsti?

@koutsie
Copy link

koutsie commented Aug 25, 2023

+1 for the fix, odd!

@grantcarthew
Copy link

grantcarthew commented Oct 29, 2023

Fresh install of EndeavourOS, same issue:

  • GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
  • mcfly 0.8.1

Thanks for the fix hferreiro

@KAGEYAM4
Copy link

$ sysctl -w dev.tty.legacy_tiocsti=1 do we still have to use this? Also does it need to be turned off when we git a fix in mcfly?

Kernel: 6.7.4-zen1-1-zen

@grantcarthew
Copy link

$ sysctl -w dev.tty.legacy_tiocsti=1 do we still have to use this? Also does it need to be turned off when we git a fix in mcfly?

Kernel: 6.7.4-zen1-1-zen

I'm still needing to run this in my terminal to be able to use McFly. The latest Kernel and updates were applied yesterday.

@yingmanwumen
Copy link

$ sysctl -w dev.tty.legacy_tiocsti=1 do we still have to use this? Also does it need to be turned off when we git a fix in mcfly?

Kernel: 6.7.4-zen1-1-zen

I'm using Debian Testing with kernel version 6.6.13-amd64, and my current mcfly of version 0.8.4 just works without any special configuration at all, although the kernel config doesn't set tiocsti:
image

@waja
Copy link

waja commented Apr 8, 2024

For me:

❯ uname -r
6.8.0-76060800daily20240311-generic
❯ cat /boot/config-6.8.0-76060800daily20240311-generic | rg TIOCSTI
# CONFIG_LEGACY_TIOCSTI is not set
❯ source /etc/os-release ; echo $VERSION
22.04.4 LTS (Jammy Jellyfish)

it is needed to set dev.tty.legacy_tiocsti=1, to work around this issue.

@grantcarthew
Copy link

This works on Arch (EndeavourOS) to make the fix survive a reboot:

echo "dev.tty.legacy_tiocsti=1" | sudo tee -a "/etc/sysctl.d/custom.conf"

@cantino
Copy link
Owner

cantino commented Apr 28, 2024

Confirmed this is #333

@cantino cantino changed the title mcfly stopped working mcfly stopped working (kernel issue) Apr 28, 2024
@Daniel15
Copy link

Is there a workaround for systems where you don't have root access?

@cantino
Copy link
Owner

cantino commented May 26, 2024

Closed, this is #333.

@cantino cantino closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants