Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto argument ordering #1042

Merged
merged 6 commits into from Mar 1, 2016
Merged

Auto argument ordering #1042

merged 6 commits into from Mar 1, 2016

Conversation

aearly
Copy link
Collaborator

@aearly aearly commented Feb 28, 2016

Closes #1036 and resolves #1023

Makes auto tasks work like standard async functions -- the callback is always the last arg.

megawac added a commit that referenced this pull request Mar 1, 2016
@megawac megawac merged commit 1b2afb5 into master Mar 1, 2016
@megawac
Copy link
Collaborator

megawac commented Mar 1, 2016

Lets get the some/every error callback stuff in and then do a prerelease @aearly

@megawac megawac deleted the auto-argument-ordering branch March 1, 2016 00:21
@aearly
Copy link
Collaborator Author

aearly commented Mar 5, 2016

I'd wait until we have all the scheduled breaking changes in. Then early adopters only have to audit their code once for 2.0.

@aearly aearly added this to the 2.0 milestone Mar 5, 2016
@PanMan
Copy link

PanMan commented Mar 22, 2016

It really confused me that this is on the main readme, while my code (on 1.x) doesn't handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants