pls consider throwing obvious error when limit is a non-positive integer

[ORESoftware]

On latest version of async

I tried (for the heck of it), a limit of 0

const async = require('async');

async.eachLimit([ 1, 2, 3 ], 0, function (item, cb) {
  console.log('item => ', item);
  process.nextTick(cb)
}, function (err) {
  console.log('error => ',err);
});

just curious what the rationale is for not throwing an error or not passing an error back in the final callback (that may be new Error('Concurrency of 0 is not valid') or whatever?

[aearly]

👍 for throwing an error, but it would be a breaking change.

[ORESoftware]

It's actually a feature because you can skip to the final callback, I just think that there should be an error there. If the user wants to ignore the error, they can do that.
Definitely understand that it would be a breaking change.

[megawac]

Closing as dupe of #1249

[megawac]

I would be fine with doing this in a minor release and considering it a bug fix. Thoughts @aearly?

[aearly]

I'd consider it a breaking change. Some people might be using or inadvertently relying on that strange behavior.