-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop lodash #1528
Drop lodash #1528
Conversation
package size minified gzipped lodash.isarraylike@4.2.0 4.54 kB 376 B 161 B
Travis -> Node 7 -> Bluebird are trying to sabotage this PR :) I don't think it's a real error.
Where to go from here? I think the build is broken. It fails the first run, it succeeds on the second run: first run
second run
|
This is impressive work! I think we might save this for a 3.0 change.
|
@@ -9,7 +9,6 @@ PACKAGE = asyncjs | |||
REQUIRE_NAME = async | |||
UGLIFY = uglifyjs | |||
XYZ = support/xyz.sh --repo git@github.com:caolan/async.git | |||
COPY_ES = sed -E "s/(import.+)lodash/\1lodash-es/g" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can remove this, I think it actually becomes just a simple cp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure of what it does exactly, what would the cp
command be exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Down below we need to copy files from lib/
to build-es/
. $(COPY_ES)
literally just becomes cp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err, cp
minus the pipe. Guess cat
would work in that case, but it's probably best to re-work the (removed) commands below slightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with how Make works, so it's perhaps best to push a commit if you have time :)
Edit: Do you mean like 83d3f73?
Alright, merging this! This will be our first 3.0 PR! If we need to make any changes to 2.x we can branch off the v2.6.1 tag. |
I'll be waiting for the drop http://pkgsize.com/async.html |
Fixes #1283 :)