Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6-ify codebase #1553

Merged
merged 32 commits into from Jul 8, 2018
Merged

ES6-ify codebase #1553

merged 32 commits into from Jul 8, 2018

Conversation

aearly
Copy link
Collaborator

@aearly aearly commented Jul 2, 2018

Lots of arrows and rest-params! I also got rid of some internal functions that were either no longer needed (slice), or better inlined (forOwn, notId, etc.)

Closes #1541

@aearly aearly added this to the 3.0 milestone Jul 2, 2018
@megawac
Copy link
Collaborator

megawac commented Jul 3, 2018

Awesome! I'm surprised you didn't have to touch the eslintrc.

How is the performance before and after making these changes? I'm most curious about the performance of restParams vs ES6 rest params and about slice vs ES6 spread

@hargasinski
Copy link
Collaborator

There's so many big changes coming in, this is awesome! LGTM.

@aearly
Copy link
Collaborator Author

aearly commented Jul 8, 2018

In Node 8 and 10, the benchmarks were about the same. No method was significantly faster or slower than another.

@aearly aearly merged commit e475117 into master Jul 8, 2018
@aearly aearly deleted the es6ify branch July 8, 2018 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants