Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove during, make test functions in until/whilst async #1557

Merged
merged 3 commits into from Jul 11, 2018

Conversation

aearly
Copy link
Collaborator

@aearly aearly commented Jul 9, 2018

Closes #850

@aearly aearly added this to the 3.0 milestone Jul 9, 2018
lib/until.js Outdated
@@ -13,15 +14,30 @@ import whilst from './whilst';
* @method
* @see [async.whilst]{@link module:ControlFlow.whilst}
* @category Control Flow
* @param {Function} test - synchronous truth test to perform before each
* execution of `iteratee`. Invoked with ().
* @param {Function} test - asynchronous truth test to perform before each
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the parameter type is AsyncFunction.

lib/doUntil.js Outdated
* @param {Function} test - synchronous truth test to perform after each
* execution of `iteratee`. Invoked with any non-error callback results of
* `iteratee`.
* @param {Function} test - asynchronous truth test to perform after each
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Sorry, same as before, I think the param type is AsyncFunction.

@hargasinski
Copy link
Collaborator

LGTM. Should we add during aliases to the two whilst functions to make migration easier?

@aearly aearly merged commit bf7f054 into master Jul 11, 2018
@aearly aearly deleted the until-no-more branch July 11, 2018 03:57
@Qix-
Copy link
Contributor

Qix- commented Jul 11, 2018

👏 :feelsgood:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants