Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat order preservation: implemented or not? #1563

Closed
alexandercerutti opened this issue Jul 20, 2018 · 6 comments
Closed

Concat order preservation: implemented or not? #1563

alexandercerutti opened this issue Jul 20, 2018 · 6 comments

Comments

@alexandercerutti
Copy link
Contributor

Hello everybody, I have a doubt about concat function order preservation. I found a merged pull request which introduces this change but the documentation still report this

There is no guarantee that the results array will be returned in the original order of coll passed to the iteratee function.

So what should I refer to? Does the function keep the order of coll?
I suppose it is preserved since it seems got introduced in v2.5.0 while we are at v2.6.0.
Thank you.

@aearly
Copy link
Collaborator

aearly commented Jul 20, 2018

The order should be preserved now, but it looks like our docs are out of date!

@alexandercerutti
Copy link
Contributor Author

That's what I supposed. Is the repository of the website available? I may do a pull request with this correction.

@aearly
Copy link
Collaborator

aearly commented Jul 20, 2018

The docs website is built from the JSDoc comments of each source file.

@alexandercerutti
Copy link
Contributor Author

Okay. I'm going to do pull request, okay?

@aearly
Copy link
Collaborator

aearly commented Jul 20, 2018

make it so

@alexandercerutti
Copy link
Contributor Author

alexandercerutti commented Jul 20, 2018

Done 😄.
I'm closing this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants