Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pack electron app #214

Open
ZweiEuro opened this issue Oct 20, 2022 · 3 comments
Open

Cannot pack electron app #214

ZweiEuro opened this issue Oct 20, 2022 · 3 comments

Comments

@ZweiEuro
Copy link

ZweiEuro commented Oct 20, 2022

Describe the bug
Cannot pack fresh electron app after creating new blank project.

To Reproduce
run this:

cd /tmp
ionic start # go through the installer, react, blank
npm i @capacitor-community/electron
ionic build
npx cap add @capacitor-community/electron
#npx cap open @capacitor-community/electron # works correctly
cd electron
npm run electron:pack #fails


Error

error TS2688: Cannot find type definition file for 'keyv'.
  The file is in the program because:
    Entry point for implicit type library 'keyv'

Expected behavior
Normal compilation for electron pack

Desktop (please complete the following information):

  • OS: Archlinux
  • Browser irrelevant (opera)
  • Version @capacitor-community/electron: 4.1.2
@hotrungnhan
Copy link

hotrungnhan commented Oct 28, 2022

install package in electron folder

@ZweiEuro
Copy link
Author

ZweiEuro commented Nov 2, 2022

@hotrungnhan

running:

cd electron
npm i package
npm run electron:pack

Still fails with the same error (tried with both 'package' and 'packager')

@ZweiEuro
Copy link
Author

ZweiEuro commented Nov 3, 2022

Solved!
missing package was "keyv" didn't think it was solved this easily.
npm i keyv in the electron folder.

I am not closing the issue though since the platform command should add all its dependencies itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants