Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen in v5 seems to be broken #280

Open
WolfWalter opened this issue Feb 13, 2024 · 3 comments
Open

Splash screen in v5 seems to be broken #280

WolfWalter opened this issue Feb 13, 2024 · 3 comments

Comments

@WolfWalter
Copy link

Describe the bug
After updating to 5.0.1 the splash screen is nearly blank. But after taking a closer look the splash.png is in the upper left corner, but super tiny.

To Reproduce
Steps to reproduce the behavior:

  1. update to v5
  2. config a splash screen
  3. yarn cap open @capacitor-community/electron

Expected behavior
Show the spash.png filling the view.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version 23.10

Additional context

I guess this change is leading to this behaviour: https://github.com/capacitor-community/electron/blame/f7ce86454469e967b41c1db8f51ddb942d278ca9/src/electron-platform/ElectronSplashScreen.ts#L48

I also played around with the before and after html snippets an ran in the same issue.

@Frooger
Copy link

Frooger commented Feb 19, 2024

Its already fixed and in the main branch:
Fix: Put the image size into the splashscreen #272

but we need a new release for that at npm :)

@WolfWalter
Copy link
Author

Ok. But that is just a PR, so it is not on the main branch. There is even another PR for this issue #201

@tradingproject19
Copy link

@Frooger any plan on merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants