Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18? #314

Open
kurtcodemander opened this issue Apr 16, 2022 · 4 comments
Open

Upgrade to React 18? #314

kurtcodemander opened this issue Apr 16, 2022 · 4 comments

Comments

@kurtcodemander
Copy link

Are there any plans of upgrading dependencies to React 18?

I have updated my browser app to React 18 and when loading flexlayout-react as an ESM module from https://cdn.skypack.dev/flexlayout-react I get errors saying "You might have more than one copy of React in the same app".
@nealus
Copy link
Collaborator

nealus commented Apr 17, 2022

v0.7.0 has been updated to React 18 peer dependencies

@kurtcodemander
Copy link
Author

Perfect, thanks, that was quick!

@kurtcodemander
Copy link
Author

https://cdn.skypack.dev/flexlayout-react still imports react 17.0.1 and react-dom 17.0.1 even though it loads flexlayout-react 0.7.0. Is this a problem with cdn.skypack.dev or flexlayout-react?

https://cdn.skypack.dev/-/flexlayout-react@v0.7.0-OTpMsStSlnqGPNxVWkPy/dist=es2020,mode=imports/optimized/flexlayout-react.js

@nealus
Copy link
Collaborator

nealus commented Apr 18, 2022

found this; skypackjs/skypack-cdn#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nealus @kurtcodemander