Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Circular Dependencies with building with typescript? #347

Open
greggman opened this issue Nov 2, 2022 · 0 comments
Open

Fix Circular Dependencies with building with typescript? #347

greggman opened this issue Nov 2, 2022 · 0 comments

Comments

@greggman
Copy link
Contributor

greggman commented Nov 2, 2022

Describe the bug

When building with typescript, typescript complains there are circular dependencies. It's only a warning but nearly all typescript features are only warnings.

This issue makes it hard to setup a CI to fail on typescript warnings because I can't suppress the warnings only for FlexLayout. If there is a way to suppress those, that would also be a solution

Your Example Website or App

https://codesandbox.io/s/flexlayout-try-to-show-ts-circular-dependencies-issue-ubvmm0

Steps to Reproduce the Bug or Issue

  1. go the link above
  2. From the top left menu icon pick File->Export to Zip
  3. unzip and cd into the folder
  4. npm install, npm run build

note: I'm on node 16.17.0

Expected behavior

no warnings

instead it prints

rollup v2.79.1
bundles src/index.tsx → dist/bundle.js...
LiveReload enabled on port 35730
(!) Circular dependencies
node_modules/flexlayout-react/lib/model/BorderNode.js -> node_modules/flexlayout-react/lib/model/Utils.js -> node_modules/flexlayout-react/lib/model/TabSetNode.js -> node_modules/flexlayout-react/lib/model/BorderNode.js
node_modules/flexlayout-react/lib/model/BorderNode.js -> node_modules/flexlayout-react/lib/model/Utils.js -> node_modules/flexlayout-react/lib/model/TabSetNode.js -> node_modules/flexlayout-react/lib/model/RowNode.js -> node_modules/flexlayout-react/lib/model/BorderNode.js
node_modules/flexlayout-react/lib/model/TabSetNode.js -> node_modules/flexlayout-react/lib/model/RowNode.js -> node_modules/flexlayout-react/lib/model/TabSetNode.js
node_modules/flexlayout-react/lib/model/Utils.js -> node_modules/flexlayout-react/lib/model/TabSetNode.js -> node_modules/flexlayout-react/lib/model/Utils.js
node_modules/flexlayout-react/lib/model/BorderNode.js -> node_modules/flexlayout-react/lib/model/Utils.js -> node_modules/flexlayout-react/lib/model/BorderNode.js

Operating System

MacOS

Browser Type?

N/A

Browser Version

N/A

Screenshots or Videos

N/A

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant