"eval" in a Window is always scoped to the Window #1025

joeframbach · 2023-08-24T22:29:03Z

Describe the bug
eval has two modes -- a "direct" eval which has access to local scope, and an "indirect" eval which has access only to global scope. The eval which executes in a HappyDom document is indirect-only. Behavior in Happy-Dom is different from a real browser.

To Reproduce
Steps to reproduce the behavior:

Execute the script in node:

var HappyDom = require('happy-dom');
new HappyDom.Window().document.write(`<!doctype html>
  <script type="text/javascript">
    var globalVariable = 'globalVariableValue';
    (function () {
      var localVariable = 'localVariableValue';
      console.log(eval('globalVariable'));
      console.log(eval('localVariable'));
    })();
  </script>
`);

See output

globalVariableValue
evalmachine.<anonymous>:1
localVariable
^

ReferenceError: localVariable is not defined

Then execute this script in a browser:

    var globalVariable = 'globalVariableValue';
    (function () {
      var localVariable = 'localVariableValue';
      console.log(eval('globalVariable'));
      console.log(eval('localVariable'));
    })();

See output

globalVariableValue
localVariableValue

Expected behavior

Expected to see "globalVariableValue" and "localVariableValue" in both node and browser.

Screenshots
If applicable, add screenshots to help explain your problem.
N/A

Device:

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

happy-dom 10.11.0

Additional context
Add any other context about the problem here.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval#direct_and_indirect_eval

The text was updated successfully, but these errors were encountered:

joeframbach · 2023-08-24T22:59:47Z

I found that the eval is a "direct" eval, but the issue is that it is always scoped from the Window, not from the scope where it is called in client code.

happy-dom/packages/happy-dom/src/window/Window.ts

Line 632 in 1f59807

public eval(code: string): unknown {

Test case:

<!doctype html>
<html>
  <script type="text/javascript">
    (function () {
      console.log(eval('this.location'));
    }).call({});
  </script>
</html>

In browser:

undefined

In happy-dom:

Location {
  href: 'https://example.com',
  ...

…luate.

capricorn86 · 2023-09-06T19:11:58Z

Thanks again for reporting and contributing @joeframbach! 🙂

There is a fix released now.

You can read more about it here:
https://github.com/capricorn86/happy-dom/releases/tag/v11.0.0

joeframbach added the bug label Aug 24, 2023

joeframbach changed the title ~~"eval" in a Window is not a "direct" eval~~ "eval" in a Window is always scoped to the Window Aug 24, 2023

joeframbach added a commit to joeframbach/happy-dom that referenced this issue Aug 25, 2023

capricorn86#1025@major: Replaced window.eval with window.happyDOM.eva…

8f7bfb8

…luate.

joeframbach added a commit to joeframbach/happy-dom that referenced this issue Aug 25, 2023

capricorn86#1025@major: Replaced window.eval with window.happyDOM.eva…

159254c

…luate.

joeframbach mentioned this issue Aug 25, 2023

#1025@major: Replaced window.eval with window.happyDOM.evaluate. #1028

Closed

capricorn86 closed this as completed Sep 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"eval" in a Window is always scoped to the Window #1025

"eval" in a Window is always scoped to the Window #1025

joeframbach commented Aug 24, 2023 •

edited

Loading

joeframbach commented Aug 24, 2023

capricorn86 commented Sep 6, 2023 •

edited

Loading

"eval" in a Window is always scoped to the Window #1025

"eval" in a Window is always scoped to the Window #1025

Comments

joeframbach commented Aug 24, 2023 • edited Loading

joeframbach commented Aug 24, 2023

capricorn86 commented Sep 6, 2023 • edited Loading

joeframbach commented Aug 24, 2023 •

edited

Loading

capricorn86 commented Sep 6, 2023 •

edited

Loading