Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "g" SVG element #1034

Closed
ottoszika opened this issue Aug 29, 2023 · 1 comment
Closed

Add support for "g" SVG element #1034

ottoszika opened this issue Aug 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ottoszika
Copy link
Contributor

ottoszika commented Aug 29, 2023 •
edited

Is your feature request related to a problem? Please describe.
SVG <g> elements are parsed as HTMLUnknownElement.

Describe the solution you'd like
Following the existing conventions is enough to parse them as SVGElement.

Describe alternatives you've considered
Maybe parsing them as SVGGElement would be more precise, but this involves changing other graphic elements` behavior (circle, line, etc.) for consistency. Keeping the actual implementation untouched, the solution above works the best.
@ottoszika ottoszika added the enhancement New feature or request label Aug 29, 2023
ottoszika added a commit to ottoszika/happy-dom that referenced this issue Aug 29, 2023
@ottoszika
capricorn86#1034@minor: Add support for g SVG element.
42a6323
capricorn86 added a commit that referenced this issue Sep 14, 2023
@capricorn86
Merge pull request #1035 from ottoszika/task/1034-add-g-svg-element
f822110 
#1034@minor: Add support for g SVG element.
@capricorn86
Copy link
Owner

@ottoszika your fix has been released 🙂

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v11.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ottoszika @capricorn86