Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic in whenAsyncComplete #1102

Closed
capricorn86 opened this issue Sep 29, 2023 · 0 comments · Fixed by #1104
Closed

Improve logic in whenAsyncComplete #1102

capricorn86 opened this issue Sep 29, 2023 · 0 comments · Fixed by #1104
Labels
bug Something isn't working

Comments

@capricorn86
Copy link
Owner

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@capricorn86 capricorn86 added the bug Something isn't working label Sep 29, 2023
capricorn86 added a commit that referenced this issue Sep 29, 2023
@capricorn86
#1102@minor: Uses vm.Script for setting globals instead of a string t…
9700666 
…o improve performance.
@capricorn86 capricorn86 changed the title whenAsyncComplete is executed too early sometimes Improve logic in whenAsyncComplete Sep 30, 2023
capricorn86 added a commit that referenced this issue Sep 30, 2023
@capricorn86
#1102@patch: Improves logic in whenAsyncComplete, to ensure that the …
2c1ff00 
…Promise is resolved after all async tasks.
@capricorn86 capricorn86 linked a pull request Sep 30, 2023 that will close this issue
Task/1102 Improve logic in whenAsyncComplete #1104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task/1102 Improve logic in whenAsyncComplete capricorn86/happy-dom
1 participant
@capricorn86