Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary interfaces as types #1330

Closed
capricorn86 opened this issue Mar 18, 2024 · 0 comments · Fixed by #1331
Closed

Remove unnecessary interfaces as types #1330

capricorn86 opened this issue Mar 18, 2024 · 0 comments · Fixed by #1331
Assignees
@capricorn86
Labels
enhancement New feature or request

Comments

@capricorn86
Copy link
Owner

capricorn86 commented Mar 18, 2024 •
edited

Is your feature request related to a problem? Please describe.
The main reason for using interfaces as types in Happy DOM is to avoid circular dependencies (e.g. Window => Document => Window)

Describe the solution you'd like
Remove unnecessary interfaces as types for Window, Node and Element classes and classes that has a dependency to them
@capricorn86 capricorn86 added the enhancement New feature or request label Mar 18, 2024
@capricorn86 capricorn86 self-assigned this Mar 18, 2024
capricorn86 added a commit that referenced this issue Mar 19, 2024
@capricorn86
BREAKING CHANGE: [#1330] Removes interfaces for Node's, as they are n…
d7c7d45 
…o longer needed as newer versions of Typescript can handle circular dependencies
@capricorn86 capricorn86 linked a pull request Mar 19, 2024 that will close this issue
BREAKING CHANGE: [#1330] Removes interfaces for Node's, as they are n… #1331
Merged
capricorn86 added a commit that referenced this issue Mar 19, 2024
@capricorn86
chore: [#1330] Fixes problem with import of Window in jest-environment
121fb40
capricorn86 added a commit that referenced this issue Mar 19, 2024
@capricorn86
chore: [#1330] Fixes wrong imports in unit tests
4edd575
capricorn86 added a commit that referenced this issue Mar 19, 2024
@capricorn86
chore: [#1330] Fixes wrong imports in unit tests
04be9be
capricorn86 added a commit that referenced this issue Mar 19, 2024
@capricorn86
chore: [#1330] Fixes wrong imports in unit tests
32d51ea
capricorn86 added a commit that referenced this issue Mar 19, 2024
@capricorn86
Merge pull request #1331 from capricorn86/1330-remove-node-interfaces…
8fc9edc 
…-as-types

BREAKING CHANGE: [#1330] Removes interfaces for Node's, as they are n…
@capricorn86 capricorn86 changed the title Remove Node interfaces as types Remove unnecessary interfaces as types Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capricorn86 capricorn86

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: [#1330] Removes interfaces for Node's, as they are n… capricorn86/happy-dom
1 participant
@capricorn86