Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMTokenList should be iterable #1342

Closed
silverwind opened this issue Mar 20, 2024 · 0 comments · Fixed by #1365
Closed

DOMTokenList should be iterable #1342

silverwind opened this issue Mar 20, 2024 · 0 comments · Fixed by #1365
Labels
bug Something isn't working

Comments

@silverwind
Copy link
Contributor

silverwind commented Mar 20, 2024 •
edited

Describe the bug
DOMTokenList is currently not iterable in happy-dom while it is in jsdom, Firefox and Chrome.

The iterator should function exactly the same as DOMTokenList#values().

To Reproduce

const div = document.createElement("div");
div.classList.add("foo", "bar");
for (const cls of div.classList) console.log(cls);

Expected behavior
Outputs foo\nbar\n.

Actual behaviour
TypeError: div.classList is not iterable
@silverwind silverwind added the bug Something isn't working label Mar 20, 2024
@silverwind silverwind mentioned this issue Mar 21, 2024
Merged
silverwind added a commit to go-gitea/gitea that referenced this issue Mar 21, 2024
@silverwind
Switch to happy-dom for testing (#29948)
8297958 
Use `happy-dom` again in vitest as it has caught up recently to `jsdom`
in terms of features and it is a much more lightweight solution.

I encountered [one
bug](capricorn86/happy-dom#1342), but it's an
easy workaround until fixed.

I regenerated the lockfile to get rid of the transitive dependencies so
that's why the diff also has some upgrades in it.

In total, this change removes 39 npm dependencies.
@silverwind silverwind mentioned this issue Mar 25, 2024
Merged
silverwind added a commit to silverwind/happy-dom that referenced this issue Mar 25, 2024
@silverwind
fix: [capricorn86#1342] Make DOMTokenList iterable
fb2f1cb
capricorn86 added a commit that referenced this issue Mar 25, 2024
@capricorn86
Merge pull request #1365 from silverwind/iterable
ee51a80 
fix: [#1342] Make `DOMTokenList` iterable
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 26, 2024
@silverwind @earl-warren
Switch to happy-dom for testing (#29948)
f8060bb 
Use `happy-dom` again in vitest as it has caught up recently to `jsdom`
in terms of features and it is a much more lightweight solution.

I encountered [one
bug](capricorn86/happy-dom#1342), but it's an
easy workaround until fixed.

I regenerated the lockfile to get rid of the transitive dependencies so
that's why the diff also has some upgrades in it.

In total, this change removes 39 npm dependencies.

(cherry picked from commit 82979588f4d8699097451ebb70c56a4bdd090c52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#1342] Make DOMTokenList iterable silverwind/happy-dom
1 participant
@silverwind