dataset camel case incorrect

[quantuminformation]

This situation camel case is not understood, whereas in the real DOM it is

[capricorn86]

Thank you for reporting @quantuminformation! 🙂

I have fixed the issue now, together with adding support for reflecting all changes done to the dataset object with the attributes.

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v2.53.0

[quantuminformation]

top man

[quantuminformation]

Wonder if this is related, I am doing a query for the dom and it's always false

export const loadedVideo = `<video data-play-index="1"  data-fully-loaded="true"></video>`

and in my test I assign above to the body and this dataset.fullyLoaded is always false

 const videoEl = document.querySelector(
        `[data-play-index="${this.videoPlayIndex + 1}"]`
      ) as HTMLVideoElement
      if (!videoEl!.dataset.fullyLoaded) {

[capricorn86]

@quantuminformation I tested this in Happy DOM now by running the following code:

element.setAttribute('data-fully-loaded', 'true');
expect(element.dataset.fullyLoaded).toBe('true');

It seems to work as expected.

[quantuminformation]

what version?

[capricorn86]

Latest version (v2.55.0), but it should work from v2.53.0

[capricorn86]

You can test it here:
https://runkit.com/capricorn86/6247045b60a3c300084cdf73

[quantuminformation]

my bad it wasn’t installed in my packages

On Fri, 1 Apr 2022 at 16:01, David Ortner ***@***.***> wrote: You can test it here: https://runkit.com/capricorn86/6247045b60a3c300084cdf73 — Reply to this email directly, view it on GitHub <#435 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABU35QHK7S4QPJJVZLKYGDVC36T3ANCNFSM5SBXVDEA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Kind regards *Nikos Katsikanis* <https://nikoskatsikanis.com> *Tech Innovation* | *Podcast Host*

[quantuminformation]

I wonder if this might be missing too:
TypeError: window.XMLHttpRequest is not a constructor

[quantuminformation]

confirmed, error not there when switching to jsdom