Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement VM inside Happy DOM #454

Closed
capricorn86 opened this issue Apr 14, 2022 · 0 comments · Fixed by #458
Closed

Implement VM inside Happy DOM #454

capricorn86 opened this issue Apr 14, 2022 · 0 comments · Fixed by #458
Assignees
@capricorn86
Labels
enhancement New feature or request

Comments

@capricorn86
Copy link
Owner

In order to solve general issues with native classes not being the same as what is used by the Javascript engine when inside a VM, Happy DOM should by default always be in a VM (e.g. [].constructor is not window.Array).

There has to be an alternative Window that is not a VM context for apps that want to run Happy DOM within the global scope.

Another problem is that timers are handled separately within a VM and globally. This got apparent when we where attempting to move to ES6 for some reason.

This change might be breaking.
capricorn86 pushed a commit that referenced this issue Apr 14, 2022
@davidortnercybercom
#454@trivial: Starts on implementation.
a348579
@capricorn86 capricorn86 added the enhancement New feature or request label Apr 14, 2022
@capricorn86 capricorn86 self-assigned this Apr 14, 2022
capricorn86 added a commit that referenced this issue Apr 20, 2022
@capricorn86
#454@trivial: Continues on making Window a VM context.
69ee9c7
capricorn86 pushed a commit that referenced this issue Apr 21, 2022
@davidortnercybercom
#454@trivial: Continue on making Window a VM context.
0a670ad
capricorn86 added a commit that referenced this issue Apr 21, 2022
@capricorn86
#454@trivial: Continues on making Window a VM context.
546c10a
capricorn86 pushed a commit that referenced this issue Apr 22, 2022
@davidortnercybercom
#454@trivial: Continue on making Window a VM context.
891372a
capricorn86 added a commit that referenced this issue Apr 25, 2022
@capricorn86
#454@minor: Solves general problems with globals (Array, Object etc.)…
1b3a793 
… inside a VM by contextifying Window when it is created. Adds a new class called GlobalWindow which lives in the global context and will not be contextified.
capricorn86 pushed a commit that referenced this issue Apr 26, 2022
@davidortnercybercom
#454@trivial: Continue on making Window a VM context.
6e2b915
@capricorn86 capricorn86 linked a pull request Apr 26, 2022 that will close this issue
Task/454 implement vm inside happy dom #458
Merged
capricorn86 pushed a commit that referenced this issue Apr 26, 2022
@davidortnercybercom
#454@major: Makes the Window instance a VM context. Adds support for …
0957ed5 
…a new window called GlobalWindow, that will run in the global context. Changes target language from ES5 to ES2020 (module resolvement will still be CommonJS).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capricorn86 capricorn86

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task/454 implement vm inside happy dom capricorn86/happy-dom
1 participant
@capricorn86