New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disabled attribute rendered with 'false' instead of '' #578
Comments
@Ken-vdE Curious why this was closed and re-opened as a |
@pkgray you can view the mentioned issue above. More information is given there. |
When I switch back to jsdom, this issue is no longer a problem, so I think it is caused by happy-dom |
…ted to parsing complex HTML. This will improve performance significantly.
…ted to parsing complex HTML. This will improve performance significantly.
…rendered-with-false-instead-of2 #578@minor: Refactors the XML parser, which fixes several issues rela…
Thank you for reporting @Ken-vdE and @pkgray! 🙂 The issue has been fixed now. You can read more about the release here: |
The original issue can be found here: vuejs/test-utils#1759
The disabled attribute gets set to 'false', which is incorrect.
The spec does not allow for false values, as per https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attributes.
The issue arises here (using Vue Test Utils):
And running a test like this:
Does not work because the this.attributes().disabled (in Test Utils baseWrapper) returns 'false' instead of undefined...
That means the dom was rendered incorrectly (
... disabled="false"
instead of not having disabled attribute).The text was updated successfully, but these errors were encountered: