Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalRegistrator unregister only deletes/pops half the registered keys #603

Closed
luca992 opened this issue Oct 10, 2022 · 0 comments · Fixed by #604
Closed

GlobalRegistrator unregister only deletes/pops half the registered keys #603

luca992 opened this issue Oct 10, 2022 · 0 comments · Fixed by #604
Assignees
Labels
bug Something isn't working

Comments

@luca992
Copy link
Contributor

luca992 commented Oct 10, 2022

Sorry, my pr #584 introduces a regression where only half the keys get deleted from global in unregister. Additionally only half the key get popped from registered
This is because I popped from the list being iterated through.

luca992 added a commit to luca992/happy-dom that referenced this issue Oct 10, 2022
…age where unregister only deletes/pops half the registered keys
luca992 added a commit to luca992/happy-dom that referenced this issue Oct 10, 2022
…age where unregister only deletes/pops half the registered keys.
capricorn86 added a commit that referenced this issue Oct 10, 2022
#603@patch: Fixes problem in the "global-registrator" package  where unregister only deletes/pops half the registered keys
@capricorn86 capricorn86 added the bug Something isn't working label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants