Element.matches producing false positives when using descendant combinators

[IGx89]

Describe the bug
When using a descendant combinator (" ") with Element.matches, if the rightmost selector matches it always returns true regardless of the other selectors.

I ran into this bug when using vue-test-utils's Wrapper.findAll, which under the scenes uses Element.matches.

To Reproduce
Given the following HTML:

<div class="red">
   <div>
      <div class="active"></div>
   </div>
</div>

The following two statements, running on the innermost div (the one with class="active") both return true even though the second should return false:

element.matches('div.red div.active');
element.matches('div.green div.active');

Expected behavior
Invalid matches should always return false.

Device:

• OS: Windows
• Browser: happy-dom
• Version: latest

[capricorn86]

Thanks for reporting @IGx89! 🙂

Just to confirm, by latest you mean v7.5.7? I made a fix for Element.matches() in v7.5.0.

[IGx89]

Yep! I have a PR coming shortly actually, would be here already but the pre-commit hooks take quite a while to complete on my machine :p.

[capricorn86]

Nice ⭐

[capricorn86]

Thanks again for you contribution!

it has been released:
https://github.com/capricorn86/happy-dom/releases/tag/v7.5.8