New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sync-request with sync-fetch #650
Comments
Thank you for reporting @ypconstante! 🙂 Me and @Mas0nShi are working on a fix for this in a related PR: We will replace sync-request with a very minimal custom solution. |
Related to #463 |
We have now fixed this by replacing "sync-request" with a custom solution 🙂 You can read more about the release here: |
Re-opening as I just noticed that the dependency in package.json is still there. |
…-dependency #650@patch: Removes the sync-request dependency as it is no longer in…
The dependency has removed now in this release: |
Is your feature request related to a problem? Please describe.
Today happy-dom uses sync-request to handle situations were a synchronous request is necessary, but this library isn't maintained anymore (last release was 4 years ago), and requires a lot of packages not used by happy-dom or it's dependencies.
Describe the solution you'd like
Migrate to sync-fetch, which is an actively maintained library that uses node-fetch, like happy-dom, which should help reduce happy-dom install size by 3Mb
Describe alternatives you've considered
.
Additional context
.
The text was updated successfully, but these errors were encountered: