Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#681@minor: Add scrollX, scrollY, pageXOffset, pageYOffset to window. #681

Merged

Conversation

00defeat
Copy link
Contributor

Add scrollX, scrollY, pageXOffset and pageYOffset to Window

@00defeat 00defeat changed the title #681@patch: Add scrollX, scrollY, pageXOffset, pageYOffset to window. #681@minor: Add scrollX, scrollY, pageXOffset, pageYOffset to window. Dec 19, 2022
@Mas0nShi
Copy link
Contributor

Fixes #680

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Ben2HellAndBack! 🌟 Just found some very minor things.

packages/happy-dom/src/window/Window.ts Outdated Show resolved Hide resolved
packages/happy-dom/src/window/Window.ts Outdated Show resolved Hide resolved
@capricorn86 capricorn86 self-requested a review December 21, 2022 23:23
@00defeat
Copy link
Contributor Author

NP! @capricorn86 all fixed up now 👍

@capricorn86 capricorn86 merged commit 3ef9a2a into capricorn86:master Jan 4, 2023
@00defeat 00defeat deleted the add-scrollX-and-scrollY-to-window branch January 10, 2023 15:11
@00defeat 00defeat restored the add-scrollX-and-scrollY-to-window branch January 10, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants