Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

direct write document.title does not work #785

Closed
lovetingyuan opened this issue Feb 24, 2023 · 2 comments · Fixed by #786
Closed

direct write document.title does not work #785

lovetingyuan opened this issue Feb 24, 2023 · 2 comments · Fixed by #786
Labels
bug Something isn't working

Comments

@lovetingyuan
Copy link

Describe the bug
I use document.title = 'title', but this does not work.

To Reproduce
Steps to reproduce the behavior:

  1. open https://stackblitz.com/edit/node-jyhhtp?file=package.json,index.mjs
  2. run node index.mjs

Expected behavior
described in the link above.

Device:

  • nodejs v16.14.2
@lovetingyuan lovetingyuan added the bug Something isn't working label Feb 24, 2023
btea added a commit to btea/happy-dom that referenced this issue Feb 24, 2023
@btea
capricorn86#785@minor: Add document.title.
5e19bc3
@btea btea mentioned this issue Feb 24, 2023
Merged
capricorn86 added a commit that referenced this issue Feb 25, 2023
@capricorn86
Merge pull request #786 from btea/task/785-add-document-title
1814f62 
#785@minor: Add document.title.
@capricorn86
Copy link
Owner

Thanks for reporting @lovetingyuan! 🙂

Big thanks to @btea for providing with a fix! ⭐

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v8.8.0

@lovetingyuan
Copy link
Author

wow, thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#785@minor: Add document.title. btea/happy-dom
2 participants
@lovetingyuan @capricorn86