Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected errors should be 'ignored' when loading network resources #816

Open
Mas0nShi opened this issue Mar 8, 2023 · 3 comments
Open
Labels
bug Something isn't working

Comments

@Mas0nShi
Copy link
Contributor

Mas0nShi commented Mar 8, 2023

We often find that there are parts of the web resources that don't load properly in the real world,
There may be reasons such as: invalid temporary resource, invalid third-party api, etc.

happy-dom should the same as browsers: ignore invalid requests & script loads.

@Mas0nShi Mas0nShi added the bug Something isn't working label Mar 8, 2023
@capricorn86
Copy link
Owner

@Mas0nShi I'm not sure I understand this. Is something getting stuck during the load of resources?

@Mas0nShi
Copy link
Contributor Author

Mas0nShi commented May 13, 2023

@Mas0nShi I'm not sure I understand this. Is something getting stuck during the load of resources?

I mean we have to think about the real world. For example, some websites reference expired assets. The browser skips it if it has not completed the request(http code 502 etc.). But happy-dom throws an exception and kills the process directly.(maybe? I haven't used it for a long time 🤣 but it's possible when we load a website)

@capricorn86
Copy link
Owner

@Mas0nShi I believe that I fixed parts of the problem in the latest release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants