Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowroot="<mode>" changed to shadowrootmode="<mode>" #898

Closed
crypto-scythe opened this issue May 7, 2023 · 0 comments · Fixed by #899
Closed

shadowroot="<mode>" changed to shadowrootmode="<mode>" #898

crypto-scythe opened this issue May 7, 2023 · 0 comments · Fixed by #899
Labels
bug Something isn't working

Comments

@crypto-scythe
Copy link
Contributor

Describe the bug
As described in Chrome Platform Status entry the shadowroot attribute is being deprecated in favour of the standard-tracked shadrowrootmode

To Reproduce

  • Set includeShadowRoots to true
  • Rendered output template tags have shadowroot="<mode>"

Expected behaviour

  • Rendered output template tags have shadowrootmode="<mode>"
@crypto-scythe crypto-scythe added the bug Something isn't working label May 7, 2023
crypto-scythe added a commit to crypto-scythe/happy-dom that referenced this issue May 7, 2023
@crypto-scythe
capricorn86#898@minor: Change deprecated shadowroot attribute to shad…
4d90214 
…owrootmode.
@crypto-scythe crypto-scythe mentioned this issue May 7, 2023
Merged
capricorn86 added a commit that referenced this issue May 11, 2023
@capricorn86
Merge pull request #899 from crypto-scythe/task/898-shadowroot-change…
2291dc3 
…d-to-shadowrootmode

#898@minor: Change deprecated shadowroot attribute to shadowrootmode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#898@minor: Change deprecated shadowroot attribute to shadowrootmode. crypto-scythe/happy-dom
1 participant
@crypto-scythe