Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nth-child query selector not working correctly #905

Closed
capricorn86 opened this issue May 11, 2023 · 0 comments · Fixed by #906
Closed

Nth-child query selector not working correctly #905

capricorn86 opened this issue May 11, 2023 · 0 comments · Fixed by #906
Labels
bug Something isn't working

Comments

@capricorn86
Copy link
Owner

Describe the bug
Nth-child query selector not working correctly when executing "*:nth-child(-n + 3)".

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@capricorn86 capricorn86 added the bug Something isn't working label May 11, 2023
capricorn86 added a commit that referenced this issue May 11, 2023
@capricorn86
#905@minor: Adds support for "nth-child of" query selector. Fixes but…
3c2765e 
… where nth-child did not return the correct elements when "-" was prefixed to "n". Significally improves performance of the nth query selectors.
@capricorn86 capricorn86 linked a pull request May 11, 2023 that will close this issue
#905@minor: Adds support for "nth-child of" query selector. Fixes but… #906
Merged
capricorn86 added a commit that referenced this issue May 11, 2023
@capricorn86
Merge pull request #906 from capricorn86/task/905-nth-child-query-sel…
df270ec 
…ector-not-working-correctly

#905@minor: Adds support for "nth-child of" query selector. Fixes but…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#905@minor: Adds support for "nth-child of" query selector. Fixes but… capricorn86/happy-dom
1 participant
@capricorn86