markupRegexp doesn't parse comments properly if they contain a dash in the text #916
Labels
bug
Something isn't working
Comments
gtm-nayan
added a commit
to gtm-nayan/happy-dom
that referenced
this issue
May 13, 2023
capricorn86
added a commit
to gtm-nayan/happy-dom
that referenced
this issue
May 13, 2023
…to parse comments including dash characters (-).
capricorn86
added a commit
to gtm-nayan/happy-dom
that referenced
this issue
May 13, 2023
…to parse comments including dash characters (-).
capricorn86
added a commit
that referenced
this issue
May 13, 2023
#916@patch: Handle comments with dash in text.
|
Thank you for your contribution @gtm-nayan! 🌟 Your fix has been released. You can read more about the release here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Given a comment like
<!-- svelte-xyz -->, the parser will incorrectly include a trailing--in the textContent of the comment.https://github.com/capricorn86/happy-dom/blob/07448050a759d55f220abbfe85951e9da7c1157c/packages/happy-dom/src/xml-parser/XMLParser.ts#LL14C1-L27C104
To Reproduce
Run
MARKUP_REGEXP.exec("<!-- a-b -->"), third group will havea-b --Expected behavior
The third group contains
a-bThe text was updated successfully, but these errors were encountered: