Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postMessage api does not use macroTask timing. #948

Closed
DylanPiercey opened this issue Jun 7, 2023 · 1 comment · Fixed by #947
Closed

postMessage api does not use macroTask timing. #948

DylanPiercey opened this issue Jun 7, 2023 · 1 comment · Fixed by #947
Labels
bug Something isn't working

Comments

@DylanPiercey
Copy link
Contributor

Describe the bug
The window.postMessage api uses "macro task" timing which some tools/libraries rely on to provide a shim of the setImmediate api in node js.

Currently the postMessage api implemented by HappyDOM is sync which can cause unexpected behavior.

To Reproduce
Call the postMessage api and the message event is fired synchronously.

Expected behavior
Call the postMessage api and the message event is fired asynchronously.
@DylanPiercey DylanPiercey added the bug Something isn't working label Jun 7, 2023
DylanPiercey added a commit to DylanPiercey/happy-dom that referenced this issue Jun 7, 2023
@DylanPiercey
capricorn86#948@patch: Use macro task timing for postmessage api.
bc13fde
@DylanPiercey DylanPiercey mentioned this issue Jun 7, 2023
Merged
DylanPiercey added a commit to DylanPiercey/happy-dom that referenced this issue Jun 8, 2023
@DylanPiercey
capricorn86#948@patch: Use macro task timing for postmessage api.
e6d3b1a
DylanPiercey added a commit to DylanPiercey/happy-dom that referenced this issue Jun 8, 2023
@DylanPiercey
capricorn86#948@patch: Use macro task timing for postmessage api.
bd9c92d
capricorn86 added a commit to DylanPiercey/happy-dom that referenced this issue Jul 10, 2023
@capricorn86
capricorn86#948@trivial: Use setTimeout() instead of setImmediate(). …
882bd68 
…Fixes problem in HTMLIframeElement where it did'nt load a page when setting URL by attributeafter it has been connected to DOM.
capricorn86 added a commit to DylanPiercey/happy-dom that referenced this issue Jul 10, 2023
@capricorn86
capricorn86#948@trivial: Use setTimeout() instead of setImmediate(). …
d2d0933 
…Fixes problem in HTMLIframeElement where it did'nt load a page when setting URL by attributeafter it has been connected to DOM.
capricorn86 added a commit to DylanPiercey/happy-dom that referenced this issue Jul 10, 2023
@capricorn86
capricorn86#948@trivial: Use setTimeout() instead of setImmediate(). …
a9d4522 
…Fixes problem in HTMLIframeElement where it did'nt load a page when setting URL by attributeafter it has been connected to DOM.
capricorn86 added a commit to DylanPiercey/happy-dom that referenced this issue Jul 10, 2023
@capricorn86
capricorn86#948@trivial: Use setTimeout() instead of setImmediate(). …
b4b19ce 
…Fixes problem in HTMLIframeElement where it did'nt load a page when setting URL by attributeafter it has been connected to DOM.
capricorn86 added a commit to DylanPiercey/happy-dom that referenced this issue Jul 10, 2023
@capricorn86
capricorn86#948@trivial: Use setTimeout() instead of setImmediate(). …
9427f4b 
…Fixes problem in HTMLIframeElement where it did'nt load a page when setting URL by attributeafter it has been connected to DOM.
capricorn86 added a commit that referenced this issue Jul 10, 2023
@capricorn86
Merge pull request #947 from DylanPiercey/post-message-timing
999fce1 
#948@patch: Use macro task timing for postmessage api.
@capricorn86
Copy link
Owner

Your fix has been released.

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v10.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#948@patch: Use macro task timing for postmessage api. DylanPiercey/happy-dom
2 participants
@DylanPiercey @capricorn86