Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling getRootNode on document should return document but returns null #950

Closed
Schleuse opened this issue Jun 22, 2023 · 1 comment · Fixed by #951
Closed

Calling getRootNode on document should return document but returns null #950

Schleuse opened this issue Jun 22, 2023 · 1 comment · Fixed by #951
Labels
bug Something isn't working

Comments

@Schleuse
Copy link
Contributor

Schleuse commented Jun 22, 2023 •
edited

Describe the bug
Calling getRootNode() on document should return the document but returns null

To Reproduce
Call getRootNode() on document

Expected behavior
It should return document but return's null

See Note above getRootNode in the Spec
@Schleuse Schleuse added the bug Something isn't working label Jun 22, 2023
Schleuse pushed a commit to Schleuse/happy-dom that referenced this issue Jun 22, 2023
capricorn86#950@patch: Calling getRootNode on document should return …
8db5039 
…the document.
@Schleuse Schleuse mentioned this issue Jun 22, 2023
Merged
Schleuse added a commit to Schleuse/happy-dom that referenced this issue Jul 10, 2023
@Schleuse
Merge branch 'capricorn86:master' into task/capricorn86#950-Calling-g…
c0884eb 
…etRootNode-on-document-should-return-the-document
capricorn86 added a commit to Schleuse/happy-dom that referenced this issue Jul 10, 2023
@capricorn86
Merge branch 'master' into task/capricorn86#950-Calling-getRootNode-o…
8c292e5 
…n-document-should-return-the-document
capricorn86 added a commit that referenced this issue Jul 10, 2023
@capricorn86
Merge pull request #951 from Schleuse/task/#950-Calling-getRootNode-o…
a06b764 
…n-document-should-return-the-document

#950@patch: Calling getRootNode on document should return the document.
@capricorn86
Copy link
Owner

Your fix has been released 🙂

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v10.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#950@patch: Calling getRootNode on document should return the document. Schleuse/happy-dom
2 participants
@Schleuse @capricorn86