Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if createRavenMiddleware is called more than once #51

Open
captbaritone opened this issue Jan 4, 2018 · 0 comments
Open

Warn if createRavenMiddleware is called more than once #51

captbaritone opened this issue Jan 4, 2018 · 0 comments

Comments

@captbaritone
Copy link
Owner

Currently this is the source of a potential memory leak (see #50), since Raven will continue to hold a reference our original dataCallback which has the store implicitly bound into it.

Additionally, we hard code where in the context we put the state, (data.extra.state), so the second call will cause any context provided by the first call to be overwritten.

I can foresee a possible use case where a user might have n different Redux stores on a given page, and might want to record context about all of them so let's have the warning include a link to our documentation where we can explain these things and give people a chance to request support for multiple calls.

I'll wrap the link in an http://bit.ly URL shortener so that we can track how many people are hitting the warning and clicking through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant