Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling on main window & playlist is too fast #1225

Open
milkmuffin opened this issue Aug 11, 2023 · 1 comment
Open

Scrolling on main window & playlist is too fast #1225

milkmuffin opened this issue Aug 11, 2023 · 1 comment

Comments

@milkmuffin
Copy link

milkmuffin commented Aug 11, 2023

I am on Windows 10 using Chrome.

I have noticed that scrolling on the main window has intention to change the volume. When I do this though, it's jumping to 0% or 100%.

A similar behaviour happens when I try and scroll the playlist. It scrolls very rapidly, tending towards the top or bottom.

I suspect the related code is:

return dispatch(setVolume(currentVolume + e.deltaY));
@milkmuffin
Copy link
Author

milkmuffin commented Aug 11, 2023

I'm not sure about the dispatch now. I was trying to peek at the messages being sent to the store, and I don't think they're getting sent.
Confirmed that it's dispatching this function:

(dispatch, getState) => {
                const currentVolume = getState().media.volume;
                return dispatch(media_setVolume(currentVolume + e.deltaY));
              }

I'm also noticing this error in the console.

Unable to preventDefault inside passive event listener invocation. (which is reproducible on webamp.org).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant