Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillMount will be deprecated soon #285

Open
1 task done
TimothyJones opened this issue May 20, 2019 · 7 comments
Open
1 task done

componentWillMount will be deprecated soon #285

TimothyJones opened this issue May 20, 2019 · 7 comments

Comments

@TimothyJones
Copy link

TimothyJones commented May 20, 2019

I'm submitting a ...

  • feature request (kinda)

In the future, componentWillMount is going to be deprecated. Looks like this is going to be in the next version of react, as 16.9.0-alpha.0 generates the following warning:

react-dom.development.js:11963 Warning: componentWillMount is deprecated and 
   will be removed in the next major version. Use componentDidMount instead. As a 
   temporary workaround, you can rename to UNSAFE_componentWillMount.

Please update the following components: Sticky

Learn more about this warning here:
https://fb.me/react-async-component-lifecycle-hooks

Demo here

If you'd like, I can make a PR fixing this.

@macrozone
Copy link

would be cool if this would be fixed soon!

@annetters
Copy link

annetters commented Sep 6, 2019

My console is now getting a big yellow warning about componentWillMount being deprecated. Will react-sticky be updated soon so we can get rid of this error?

image

@gerhat
Copy link

gerhat commented Sep 20, 2019

Here is a pull request for the warning: #292

@Indigo744
Copy link

Since it seems this lib is dead (#291), does anyone know a worthy alternative that plays nice with React 16.11?

@zidianlyu
Copy link

Any updates on this? Thanks!

@ebrearley
Copy link

ebrearley commented Aug 19, 2020

I normally hate this kind of thing, but since React 17 is now in RC, I've forked and merged #292 as a stop gap between now and the revival of this repo.

Published to npm as react-sticky-17.

My apologies go out to the maintainers of this repository.

@TimothyJones
Copy link
Author

@ebrearley: That's great, thanks for taking the initiaive!

There's a note in the readme of this repo that it won't be maintained any more (since Oct 2019), so I think a fork is probably appropriate. Are you able to maintain your fork moving forward? Happy to help out if it will make the difference between a yes and a no :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants