Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare package for v1 + Svelte 5 readiness #1877

Open
3 tasks
theetrain opened this issue Jan 2, 2024 · 1 comment
Open
3 tasks

Prepare package for v1 + Svelte 5 readiness #1877

theetrain opened this issue Jan 2, 2024 · 1 comment
Milestone

Comments

@theetrain
Copy link
Collaborator

theetrain commented Jan 2, 2024

Before publishing v1 package:

  • Set svelte version in package.json peerDependencies to ^3.55.1 || ^4.0.0 || ^5.0.0
  • Ensure 'getting started' documentation is up-to-date
  • Documentation related to styling is up-to-date
@theetrain theetrain added this to the v1.0.0 milestone Jan 2, 2024
@theetrain theetrain mentioned this issue Jan 16, 2024
4 tasks
@theetrain theetrain changed the title Prepare package for v1 Prepare package for v1 + Svelte 5 readiness Apr 28, 2024
@theetrain
Copy link
Collaborator Author

theetrain commented Apr 28, 2024

I tried installing and testing svelte@5.0.0-next.115.

Test branch: https://github.com/carbon-design-system/carbon-components-svelte/tree/chore/svelte-5-test
Changes made: bd3ea6d

  • Switched fully to ESM
  • Removed format compiler option

I ran the docs: cd docs && yarn dev, but then ran into this runtime error:

Uncaught TypeError: Cannot read properties of undefined (reading 'call')

Which points to this presumably svelte-generated code:

function clone_node(node, deep) {
  return (
    /** @type {N} */
    clone_node_method.call(node, deep)
//  ^ this is `undefined`
  );
}

Going to try coming back to this later and find out why this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant