Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PasswordInput v11 #1890

Open
2 tasks
Tracked by #1629
theetrain opened this issue Jan 14, 2024 · 5 comments
Open
2 tasks
Tracked by #1629

PasswordInput v11 #1890

theetrain opened this issue Jan 14, 2024 · 5 comments
Assignees
Labels
v11 Carbon v11 feature

Comments

@theetrain
Copy link
Collaborator

theetrain commented Jan 14, 2024

Spun off from #1629

@theetrain theetrain changed the title PasswordInput PasswordInput v11 Jan 14, 2024
@theetrain theetrain added the v11 Carbon v11 feature label Jan 14, 2024
@SimpleProgrammingAU
Copy link
Contributor

If no one's taken this one, I'll smash it out since it should have some good overlap with TextInput.

@SimpleProgrammingAU
Copy link
Contributor

Is the tooltip for this component being removed?

The styles are still included in the component styles, but they don't do anything anymore. I've had a bit of a hunt and can't find anything definitive in the CDS documentation that states whether or not a tooltip should exist from the PasswordInput component, generally.

@theetrain
Copy link
Collaborator Author

theetrain commented Jan 20, 2024

I think similar to how #1895 (Button) makes use of the new Popover component, I think tooltip functionality is blocked by #1896, so that ticket is high priority.

If you've already started on PasswordInput, then someone can work on Popover and then later update Button and PasswordInput to make use of Popover.

I believe the React library uses a mouseenter event to activate the cds--popover--open class. I would prefer we use pure CSS or perhaps the new Popover API to achieve the full interaction.

Edit: maybe pure CSS isn't enough since aria- attributes may need to be modified. Another potential advantage for the popover API.

@SimpleProgrammingAU
Copy link
Contributor

SimpleProgrammingAU commented Jan 21, 2024

I believe the React library uses a mouseenter event to activate the cds--popover--open class. I would prefer we use pure CSS or perhaps the new Popover API to achieve the full interaction.

Were you able to get the tooltip to work with PasswordInput in CDS React v11? I couldn't see anything happening to the implemented styles in the dev tools window when I rolled over the icon with my mouse.

@SimpleProgrammingAU
Copy link
Contributor

@theetrain was just returning to this after submitting the draft for Popover and when I look at the React example, the tooltip doesn't appear anymore. What should we do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v11 Carbon v11 feature
Projects
None yet
Development

No branches or pull requests

2 participants