Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Step 3 Query Component step instructions causing errors #2923

Closed
kellychurchill opened this issue Oct 13, 2019 · 4 comments · Fixed by carbon-design-system/carbon-website#543
Assignees

Comments

@kellychurchill
Copy link
Collaborator

Instructions in step 3 are not working:
https://www.carbondesignsystem.com/tutorial/react/step-3#query-component

When following this section in step 3, the repo page is broken.

See this PR for an example: https://github.com/carbon-design-system/carbon-tutorial/pull/2894/files#submit-review

@IOIO72
Copy link

IOIO72 commented Oct 24, 2019

Here's the breaking change in apollo-react:
https://github.com/apollographql/react-apollo/blob/master/Changelog.md#potentially-breaking-change
apollographql/react-apollo#3388

So just needed to use data instead of data: {organization}, 'cause during loading or error state, the organization is undefined.

To carbon team:
Possibly just change the instructions for the Query function or change yarn add to a specific apollo-react version.

@vpicone
Copy link

vpicone commented Oct 28, 2019

@IOIO72 do you mind opening a PR on the carbon website? Would be a super big help.

https://github.com/carbon-design-system/carbon-website

@IOIO72
Copy link

IOIO72 commented Oct 29, 2019

@IOIO72 do you mind opening a PR on the carbon website? Would be a super big help.

https://github.com/carbon-design-system/carbon-website

No problem. I'll do it during the day :)

@IOIO72
Copy link

IOIO72 commented Oct 30, 2019

Additional PR: carbon-design-system/carbon-website#543

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants